Skip to content

containerruntimeconfig: watch Image CR for registries #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 17, 2019
Merged

containerruntimeconfig: watch Image CR for registries #441

openshift-merge-robot merged 1 commit into from
Feb 17, 2019

Conversation

@umohnani8
Copy link
Contributor

@umohnani8 umohnani8 commented Feb 16, 2019

Add support to watch the Image CR for registry changes
by the user. Populate /etc/containers/registries.conf
with these changes.

Signed-off-by: Urvashi Mohnani umohnani@redhat.com

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 16, 2019
@umohnani8
Copy link
Contributor Author

umohnani8 commented Feb 16, 2019

@mrunalp @runcom PTAL

@umohnani8
containerruntimeconfig: watch Image CR for registries
a795890 
Add support to watch the Image CR for registry changes
by the user. Populate /etc/containers/registries.conf
with these changes.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
@umohnani8
Copy link
Contributor Author

umohnani8 commented Feb 17, 2019 •
edited
Loading

This is ready to merge once tests are green. I didn't add a unit test for this because I am seeing some issues with the testing framework, which I am working to fix. I will open another PR with the unit tests.
Tested this on a cluster and changes are made to all nodes when the image config is added, edited/updated, and deleted. At the same time works for the container runtime config.
@mrunalp @runcom PTAL

@runcom
Copy link
Member

runcom commented Feb 17, 2019

code looks good to me
@cgwalters @kikisdeliveryservice @LorbusChris ptal as well

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2019
@mrunalp
Copy link
Member

mrunalp commented Feb 17, 2019

LGTM

@runcom
Copy link
Member

runcom commented Feb 17, 2019

all green here as well

@cgwalters
Copy link
Member

cgwalters commented Feb 17, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, runcom, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0eb517a into openshift:master Feb 17, 2019
@runcom runcom mentioned this pull request Feb 19, 2019
Merged
@umohnani8 umohnani8 deleted the registries branch January 22, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@ashcrow ashcrow Awaiting requested review from ashcrow

Assignees

@cgwalters cgwalters

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@umohnani8 @runcom @mrunalp @cgwalters @openshift-ci-robot @openshift-merge-robot